marvin
/
us144mkii
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(driver): Remove deep sleep command from suspend 

The vendor-specific deep sleep command in the suspend function can cause system freezes when the device is idle. This commit removes the command to prevent these freezes.
This commit is contained in:
Šerif Rami 2025-08-08 12:24:43 +02:00
parent ba4e73b926
commit 87ac941e35
1 changed files with 16 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
us144mkii.c
View File

@ -320,25 +320,15 @@ static void tascam_card_private_free(struct snd_card *card) {
*
* Return: 0 on success.
*/
static int tascam_suspend(struct usb_interface *intf, pm_message_t message) {
static int tascam_suspend(struct usb_interface *intf, pm_message_t message)
{
struct tascam_card *tascam = usb_get_intfdata(intf);
int err;
if (!tascam)
return 0;
/*
* The device requires a specific sequence to enter a stable low-power
* state. First, ensure all data transmission is stopped before
* sending the final vendor command.
*/
if (tascam->pcm)
snd_pcm_suspend_all(tascam->pcm);
/*
* Terminate all in-flight URBs to prevent access to the device
* after it has been put to sleep.
*/
cancel_work_sync(&tascam->stop_work);
cancel_work_sync(&tascam->capture_work);
cancel_work_sync(&tascam->midi_in_work);
@ -349,22 +339,6 @@ static int tascam_suspend(struct usb_interface *intf, pm_message_t message) {
usb_kill_anchored_urbs(&tascam->midi_in_anchor);
usb_kill_anchored_urbs(&tascam->midi_out_anchor);
/*
* Send the vendor-specific "Deep Sleep" command. Failure to send this
* command before host-initiated suspend can leave the device in an
* unstable state, leading to system freezes on idle (autosuspend).
*/
err = usb_control_msg(tascam->dev, usb_sndctrlpipe(tascam->dev, 0),
0x00, /* bRequest */
0x40, /* bmRequestType: H2D, Vendor, Device */
0x0044, /* wValue */
0x0000, /* wIndex */
NULL, /* data */
0, /* size */
1000); /* timeout */
if (err < 0)
dev_err(&intf->dev, "failed to send deep sleep command: %d\n", err);
return 0;
}