From 8d5c8ed1d0d02d7ad11fe63a28f4c5b382b3d2e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=A1s=20S=C3=A1nchez?= <nicolassanchez@tutanota.com>
Date: Tue, 24 Dec 2024 12:03:47 -0300
Subject: [PATCH] minor refactoring

---
 .../dcav2gui/ui/home/HomeFragment.java        | 23 ++++++++-----------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/app/src/main/java/com/example/dcav2gui/ui/home/HomeFragment.java b/app/src/main/java/com/example/dcav2gui/ui/home/HomeFragment.java
index 2e75d24..f5b8399 100644
--- a/app/src/main/java/com/example/dcav2gui/ui/home/HomeFragment.java
+++ b/app/src/main/java/com/example/dcav2gui/ui/home/HomeFragment.java
@@ -520,9 +520,9 @@ public class HomeFragment extends Fragment {
         }).start();
     }
 
-    private List<String> getShortWorkers(String exchange, List<InstanceInterface.WorkerStatsData> workerList) {
+    private List<String> getShortWorkers(List<InstanceInterface.WorkerStatsData> workerList) {
         List<String> shortWorkers = new ArrayList<>();
-        for (InstanceInterface.WorkerStatsData worker : MainActivity.getInstanceCache(exchange).getWorkers()) {
+        for (InstanceInterface.WorkerStatsData worker : workerList) {
             if (worker.getIsShort()) {
                 shortWorkers.add(worker.getPair());
             }
@@ -533,17 +533,12 @@ public class HomeFragment extends Fragment {
     private void showLastTradesDetailsDialog(List<InstanceInterface.DealData> result) {
         AlertDialog.Builder builder = new AlertDialog.Builder(getContext());
         List<String> shortWorkers = new ArrayList<>();
-        if (MainActivity.getInstanceCache("binance")!=null) {
-            shortWorkers.addAll(getShortWorkers("binance", MainActivity.getInstanceCache("binance").getWorkers()));
-        }
-        if (MainActivity.getInstanceCache("gateio")!=null) {
-            shortWorkers.addAll(getShortWorkers("binance", MainActivity.getInstanceCache("gateio").getWorkers()));
-        }
-        if (MainActivity.getInstanceCache("kucoin")!=null) {
-            shortWorkers.addAll(getShortWorkers("binance", MainActivity.getInstanceCache("kucoin").getWorkers()));
-        }
-        if (MainActivity.getInstanceCache("okex")!=null) {
-            shortWorkers.addAll(getShortWorkers("binance", MainActivity.getInstanceCache("okex").getWorkers()));
+        String[] exchanges = {"binance", "gateio", "kucoin", "okex"};
+
+        for (String exchange : exchanges) {
+            if (MainActivity.getInstanceCache(exchange)!=null) {
+                shortWorkers.addAll(getShortWorkers(MainActivity.getInstanceCache(exchange).getWorkers()));
+            }
         }
 
         LayoutInflater inflater = LayoutInflater.from(getContext());
@@ -570,7 +565,7 @@ public class HomeFragment extends Fragment {
         TextView titleTextView = customLayout.findViewById(R.id.trades_details_title);
         TextView detailsTextView = customLayout.findViewById(R.id.trades_details_content);
 
-        String title = exchange + "log";
+        String title = exchange + " log";
         titleTextView.setText(title);
         detailsTextView.setText(result);