From c8772a8429cf61d7b8ae6f8c8bea5ca6bc12d2b1 Mon Sep 17 00:00:00 2001 From: mb8565 <244351746+mb8565@users.noreply.github.com> Date: Tue, 11 Aug 2026 01:09:24 -0500 Subject: [PATCH] Fix rope type for 39 architectures (#2290) The DFLASH case was inserted into the NEOX fall-through group in llama_rope_type(), so the 39 cases above it now return LLAMA_ROPE_TYPE_NORM instead of LLAMA_ROPE_TYPE_NEOX. Move DFLASH into the NORM group so it keeps its intended rope type and the others fall through to NEOX again. --- src/llama.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/llama.cpp b/src/llama.cpp index 1bf9f75f..40a27c13 100644 --- a/src/llama.cpp +++ b/src/llama.cpp @@ -8782,6 +8782,7 @@ enum llama_rope_type llama_rope_type(const struct llama_model * model) { case LLM_ARCH_MISTRAL3: case LLM_ARCH_GLM_DSA: case LLM_ARCH_MISTRAL4: + case LLM_ARCH_DFLASH: return LLAMA_ROPE_TYPE_NORM; // the pairs of head values are offset by n_rot/2 @@ -8824,8 +8825,6 @@ enum llama_rope_type llama_rope_type(const struct llama_model * model) { case LLM_ARCH_LAGUNA: case LLM_ARCH_GEMMA4: case LLM_ARCH_GEMMA4_MTP: - case LLM_ARCH_DFLASH: - return LLAMA_ROPE_TYPE_NORM; case LLM_ARCH_DFLASH_DRAFT: case LLM_ARCH_GEMMA4_ASSISTANT: return LLAMA_ROPE_TYPE_NEOX;